Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: build storybook in addition to yarn build with Vercel #817

Merged
merged 4 commits into from
Jun 22, 2023
Merged

docs: build storybook in addition to yarn build with Vercel #817

merged 4 commits into from
Jun 22, 2023

Conversation

tulup-conner
Copy link
Collaborator

@tulup-conner tulup-conner commented Jun 22, 2023 •
edited
Loading

Description

We have a Storybook, but it isn't built and deployed to Vercel along with the normal docs anymore.

Type of change

  • This change contains documentation update

Breaking changes

None

How Has This Been Tested?

  • Visual inspection of Vercel deployment

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@tulup-conner tulup-conner added this to the 1.0.0 milestone Jun 22, 2023
@tulup-conner tulup-conner self-assigned this Jun 22, 2023
@vercel
Copy link

vercel bot commented Jun 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 1:30am

@tulup-conner tulup-conner marked this pull request as ready for review June 22, 2023 01:22
@tulup-conner
docs(.storybook): fix Inter font in storybook
89a3089
@tulup-conner
chore(.gitignore): ignore yarn storybook:build output
65fe36f
@tulup-conner
docs(app/components/navbar): add Button to visit storybook
be416bf
@tulup-conner
ci(.github/workflows/storybook): create workflow to always merge `mai…
0dd62e9 
…n` -> `storybook` branch

The `storybook` branch will now be a permanent fixture alongside `main`. Its purpose is to deploy to
a separate URL on Vercel so we can host the docs and `storybook` output simultaneously, since
`next.js` cannot deploy static HTML found in `storybook` output.
@tulup-conner tulup-conner merged commit e521b3e into main Jun 22, 2023
@tulup-conner tulup-conner deleted the docs/add-storybook-again branch June 22, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tulup-conner tulup-conner

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@tulup-conner